Deprecate thread_priority again #2644
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
LukasMacha97,
Maverobot,
bmagyar,
erickisos,
harderthan,
qiayuanl and
saikishor
bmagyar
reviewed
Oct 12, 2025
| /// This structure stores information about hardware defined in a robot's URDF. | ||
| #ifdef _MSC_VER | ||
| #pragma warning(push) | ||
| #pragma warning(disable : 4996) |
Member
There was a problem hiding this comment.
is this nonsense the equivalent of the dep declaration ignore?
Contributor
Author
There was a problem hiding this comment.
this is the MSVC equivalent of the gcc stuff below. There is no c++ standard equivalent for disabling [[deprecated]], this is compiler-specific.
bmagyar
approved these changes
Oct 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecation notice was silenced with #2605, I readded it and fixed its usage for backwards compatibility reasons.